-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bolt v2.6.0-beta.2 #1335
Merged
Merged
Bolt v2.6.0-beta.2 #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…install on Travis
…t/critical-path-polyfills` package when doing local development
…1-fixes v2.6.0-beta.1 Post-Release Fixes
…-background-video-prop Video | FE | Deprecate isBackgroundVideo prop
…nto feature/BDS-1695-document-npm-patch-package
…ument-npm-patch-package Document guidelines for npm `patch-package` usage
… to address a recent Sass Loader upstream change
…ilds if otherwise undefined
…o-autoplay-demo Video | Docs | Add comment about autoplay on iOS
Hotfix: Fix Sass Loader in Build Tools (Duplicate of #1361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.6.0-beta.2 Updates
Fixes
Build Tools Hotfix (Port of #1362)
v2.6.0-beta.1
Fast Follow Updates #1333@bolt/build tools
Jest snapshots to reflect minor CSS changes@bolt/critical-path-polyfills
packageDeprecations
isBackgroundVideo
prop Video | FE | Deprecate isBackgroundVideo prop #1326Documentation
patch-package
usage #1301autoplay
behavior on iOS Video | Docs | Add comment about autoplay on iOS #1347Updates released in v2.6.0-beta.1
Enhancements & Updates
New
@bolt/critical-path-polyfills
Package AddedImage Component: Performance Improvements
Modal Component
toggle
Javascript method. Modal | JS | Addtoggle
method #1327noBodyScroll
feature. This now allows the page to scroll behind the modal by default as a temporary workaround to prevent the page's content from shifting. Modal | JS | Add page scrolling option #1304Button / Trigger Component
disabled
attribute to bolt-button and bolt-trigger inner elements when prop is set. Button | HTML | Add missing 'disabled' attribute to button and trigger #1260target
prop when target is defined via Drupal's{{ attributes }}
object instead of the defaulttarget
prop. Button | Twig | Add missing 'target' attribute #1266Build Tool Improvements
@bolt/build-tools
to allow for customizing the full URL that gets proxied by Browsersync. This allows for non-Bolt provided servers (like Drupal) to benefit from live reloading when CSS and Javascript changes while doing local development! Build Tools | Dev | Update Browsersync Config To Allow Customizable Proxy Url #1237@bolt/build-tools
to add 'env' to the global data exposed to all JavaScript files (via Webpack) + wrap 'env' and 'lang' in JSON.stringify() Video | FE | Add 'env' to global JS, wrap 'env' and 'lang' in JSON.stringify #1241@bolt/build-tools
docs: add quick writeup on configuring language-specific builds in Bolt #1267openServerAtStart
config option to now try and reuse an existing browser tab previously opened. This should be a super helpful update for devs ever needing to restart the build tools while doing local development!Core Sass Style Updates
bolt-repeat-rule
mixin to repeat a block of styles as a separate rule-set for each selector provided, helps keep:host
rulesets DRY.Navbar Component
Code Snippet Component
<bolt-code-snippet>
component's Twig template to work better when Javascript is disabled / hasn't finished loading Code-snippet | Bug | Fix for code-snippet component to correct work without JS #1224Action Blocks Component
include
path inaction-block.twig
adaptor file from_action-block.twig
to_action-block-item.twig
. Added tests for adaptor file and deprecated props. Action Blocks | Testing | Update include path and add tests #1233Carousel Component
Developer Docs
Testing & Documentation Improvements
TESTING.md
manual testing steps for the Device Viewer component Device-viewer | Docs | Testing and Documentation for device-viewer component #1238Bug Fixes
@bolt/analytics-autolink
and@bolt/analytics-autotrack
packages to no longer throw a Javascript error if Google Analytics's Javascript never loads OR if a config for tracking external-bound links is undefined. Analytics | Bug | Fix Autotrack and Autolink JS Errors When GA Config / GA Script Missing #1321@bolt/build-tools
browserSync config trying to watch files for changes innode_modules
andvendor
directories which had been causing issues when trying to runbolt start
in certain project configurations. Bolt start command on external projects #1323This should fully restore the ability to run
npm start
in Drupal and utilize Webpack Dev Server and live reloading!This PR also updates our existing Drupal Lab tests to check that a temporary workaround fixes the issue in Drupal (immediate workaround using the most recent release of Bolt) + adds a new suite of tests for the latest upcoming release of our build tools. #1265
DevOps Updates
The SSR server is now running as a persistent HTTP2 server (vs CLI previously), speeding up server-side rendering to be around 128x faster (~0.01s response)!! 🎉
Before vs After Jest Test Speedup ⬆️
Incorporated several different updates to fix and improve overall testing consistency in Bolt (ex. more predictable results when running Jest tests locally vs on Travis) in addition to better handling the results from successful / failing visual regression tests. Feat: Improve Test Consistency + Better Handle VRT Failures #1272
Added a new suite of testing utilities (including a powerful new way to walk through Twig-based dependencies) + quicker Jest tests via Add dependency mapper and quicker Jest tests #1226
Added global type checking (not compiling) of Javascript files in the Bolt monorepo using TypeScript via
yarn test:types
.This update will significantly reduce our infrastructure costs with Now.sh by temporarily having all of our deployments be a static HTML deployments (ie. no PHP services and no Docker containers). The only main drawback with this update is that our Twig Rendering Service / Component Explorer needs to be temporarily disabled until we've finished working on getting this to work on Now.sh's new serverless architecture (lots of progress has been made on this thankfully!).
For the time being, a Component Explorer placeholder + message has been aded on all component docs pages this particular feature had been getting used -- namely on the Button, Navbar, and Carousel component sections in Pattern Lab.
Added a new monorepo helper script to automatically update NPM dependencies in packages not managed by directly by Lerna (ex. the example integration demos using Vue, Angular, Drupal Lab, etc). Example integrations auto dependencies update #1205
DevOps related updates to upgrade Bolt’s Puppeteer instances to now use
Puppeteer Core
+ launch using an instance of Chrome already installed; significantly speeding up / slimming down local dev installs + shaving nearly a minute off of our Travis CI build! Improve UIKit Rendering Performance + Speed Up CI Installs #1255Also includes a handful of UIKit visual improvements + a ton of IE-specific bug fixes that popped up when testing out these updates.
Before:
After:
Deprecations
generator-bolt
to@bolt/generator-bolt
to avoid publishing issues due to NPM namespace permissions. Chore: Rename Yeoman Component Generator's Package.json Name #1305The old NPM package now points people to use the renamed package (including when installing the old NPM package via the command line).
Pre-Released in
v2.5.3/4
@bolt/components-trigger
as an NPM dependency of@bolt/components-modal
so this sub-component gets automatically NPM installed if it isn't manually listed out in apackage.json
. Fix: add trigger as dependency for modal #1229sizes
prop in nested images to be overwritten with a less optimized config. Hotfix: Remove Device Viewer Logic Overriding The Image Component'sSizes
Prop #1257--config-file
option to restore multiple language-specific builds Next Bolt Release: v2.6.0 #1232<bolt-text>
component CSS to address a minor Sass-related regression in IE that had been causing the outer container to not display the correctdisplay
ormargin
styles. Fix bolt-text component spacing in IE #1231Details
The
slot="footer"
was accidentally being used on the figcaption's container, which was a carryover from an older prototype.